Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add omerc to projections list #2146

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Conversation

bjlittle
Copy link
Member

This PR is a follow-up to #2096.

See this comment.

@@ -60,7 +59,7 @@ AzimuthalEquidistant
import matplotlib.pyplot as plt
import cartopy.crs as ccrs

plt.figure(figsize=(3, 3))
plt.figure(figsize=(3.0101, 3))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this value come from? Seems like it was OK on the current docs: https://scitools.org.uk/cartopy/docs/latest/reference/projections.html#azimuthalequidistant

Same with the Orthographic update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Struck me as kinda odd too.

I simply done a make projection and this is the automated change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want me to revert that particular auto-change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, the width is taken from the x_limits of each projection, so my guess is this has to do with PROJ updating some of their limits with a version bump at some point...

@greglucas greglucas merged commit 38b06c0 into SciTools:main Mar 12, 2023
@greglucas
Copy link
Contributor

@bjlittle looks like this one didn't run the pre-commit.ci on the PR since it was in beforehand. Can you also fix the end-of-file in your upcoming PR? Might be a little more work and require a trailing newline in the make_projection.py script to be more robust for the future too.

@bjlittle
Copy link
Member Author

Awesome, thanks @greglucas

@greglucas greglucas added this to the 0.22 milestone Mar 12, 2023
@bjlittle bjlittle deleted the omerc-followup branch March 12, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants